Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added case-insensitive search functionality for filtering cards based… #671

Closed
wants to merge 1 commit into from

Conversation

royvivi29
Copy link

@royvivi29 royvivi29 commented Oct 24, 2024

Pull Request Format

Issue #657 : Troubleshoot search issues: Common Causes and solution solved

Type of PR

  • Add X in the box to specify the improvement type.
  • [X ] Feature enhancement

Description

Updated the performSearch function to allow case-insensitive search by converting both the search input and card heading text to lowercase for comparison. This ensures that users can search for cards without worrying about letter case, improving the user experience.

Screenshots / Videos (if applicable)

image ![Screenshot 2024-10-24 141818](https://github.com/user-attachments/assets/747c00bb-6447-4e6a-8831-ea2263777ece)

Checklist

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • [X ] I have tested the changes thoroughly before submitting this pull request.
  • [X ] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [ X] I have commented my code, particularly in hard-to-understand areas.

Thank you for reviewing my pull request!

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 8:51am

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit 9ccba22
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/671a0a9aa737a90008b27d80
😎 Deploy Preview https://deploy-preview-671--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @royvivi29! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

1 similar comment
Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@royvivi29
Copy link
Author

@swaraj-das please assign me and merge this

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

2 similar comments
Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: None

@github-actions github-actions bot added the Stale label Nov 6, 2024
@github-actions github-actions bot closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant